This repository was archived by the owner on Feb 25, 2024. It is now read-only.
Fix wrong status line error #3
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems legit. Thanks for the effort! |
|
@ainformatico sorry if I'm missing something here. What would you want the test to verify besides what the current spec file is doing? |
|
We should ensure the same error is not raised therefore a test forcing SSL and checking that the error is not raised. Sorry for the delay, notifications won't work for me and went on holidays. |
|
Due to the large delay I'm merging this and if you feel with the energy to open another PR with the test I would be most grateful. |
ainformatico
added a commit
that referenced
this pull request
Sep 29, 2015
Fix wrong status line error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue described in #2.